[COMMITTERS] pgsql: When WCOs are present,disable direct foreign table modification - Mailing list pgsql-committers

From Robert Haas
Subject [COMMITTERS] pgsql: When WCOs are present,disable direct foreign table modification
Date
Msg-id E1dZjvB-0000bV-VI@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
When WCOs are present, disable direct foreign table modification.

If the user modifies a view that has CHECK OPTIONs and this gets
translated into a modification to an underlying relation which happens
to be a foreign table, the check options should be enforced.  In the
normal code path, that was happening properly, but it was not working
properly for "direct" modification because the whole operation gets
pushed to the remote side in that case and we never have an option to
enforce the constraint against individual tuples.  Fix by disabling
direct modification when there is a need to enforce CHECK OPTIONs.

Etsuro Fujita, reviewed by Kyotaro Horiguchi and by me.

Discussion: http://postgr.es/m/f8a48f54-6f02-9c8a-5250-9791603171ee@lab.ntt.co.jp

Branch
------
REL9_6_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/971faefc240bf214076e529773c7ca690c5e053d

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 60 ++++++++++++++++++++++++++
contrib/postgres_fdw/sql/postgres_fdw.sql      | 24 +++++++++++
doc/src/sgml/postgres-fdw.sgml                 |  6 ++-
src/backend/optimizer/plan/createplan.c        |  7 ++-
4 files changed, 93 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Ensure that pg_get_ruledef()'s output matchespg_get_viewdef()'s
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Fix race condition in predicate-lock init code in EXEC_BACKENDb