[COMMITTERS] pgsql: Improve comments for execExpr.c's handling of FieldStoresubexpr - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Improve comments for execExpr.c's handling of FieldStoresubexpr
Date
Msg-id E1dWU8L-0002ca-QZ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Improve comments for execExpr.c's handling of FieldStore subexpressions.

Given this code's general eagerness to use subexpressions' output variables
as temporary workspace, it's not exactly clear that it is safe for
FieldStore to tell a newval subexpression that it can write into the same
variable that is being supplied as a potential input.  Document the chain
of assumptions needed for that to be safe.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/de2af6e001a3d6aeb2a10a802e73af8c7d1d3405

Modified Files
--------------
src/backend/executor/execExpr.c | 12 ++++++++++++
1 file changed, 12 insertions(+)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Improve comments for execExpr.c'sisAssignmentIndirectionExpr().
Next
From: Andrew Dunstan
Date:
Subject: [COMMITTERS] pgsql: Fix vcregress.pl PROVE_FLAGS bug in commit 93b7d9731f