[COMMITTERS] pgsql: Re-allow SRFs and window functions within sub-selects withinagg - Mailing list pgsql-committers

Re-allow SRFs and window functions within sub-selects within aggregates.

check_agg_arguments_walker threw an error upon seeing a SRF or window
function, but that is too aggressive: if the function is within a
sub-select then it's perfectly fine.  I broke the SRF case in commit
0436f6bde by copying the logic for window functions ... but that was
broken too, and had been since commit eaccfded9.

Repair both cases in HEAD, and the window function case back to 9.3.
9.2 gets this right.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9c7dc89282b3dac5685c39d4d792b02ca573c2d3

Modified Files
--------------
src/backend/parser/parse_agg.c     | 37 ++++++++++++++++++++++---------------
src/test/regress/expected/tsrf.out | 14 ++++++++++++++
src/test/regress/sql/tsrf.sql      |  6 ++++++
3 files changed, 42 insertions(+), 15 deletions(-)