Remove unnecessairly duplicated gram.y productions
Declarative partitioning duplicated the TypedTableElement productions,
evidently to remove the need to specify WITH OPTIONS when creating
partitions. Instead, simply make WITH OPTIONS optional in the
TypedTableElement production and remove all of the duplicate
PartitionElement-related productions. This change simplifies the
syntax and makes WITH OPTIONS optional when adding defaults, constraints
or storage parameters to columns when creating either typed tables or
partitions.
Also update pg_dump to no longer include WITH OPTIONS, since it's not
necessary, and update the documentation to reflect that WITH OPTIONS is
now optional.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b9a3ef55b253d885081c2d0e9dc45802cab71c7b
Modified Files
--------------
doc/src/sgml/ref/create_foreign_table.sgml | 2 +-
doc/src/sgml/ref/create_table.sgml | 4 +-
src/backend/parser/gram.y | 68 ++++++++++--------------------
src/bin/pg_dump/pg_dump.c | 17 +++++---
src/test/regress/expected/create_table.out | 2 +-
src/test/regress/expected/sanity_check.out | 3 ++
src/test/regress/expected/typed_table.out | 37 ++++++++++++++--
src/test/regress/sql/create_table.sql | 2 +-
src/test/regress/sql/typed_table.sql | 21 ++++++++-
9 files changed, 94 insertions(+), 62 deletions(-)
