[COMMITTERS] pgsql: Don't call the function that may raise an error while holdingsp - Mailing list pgsql-committers

From Fujii Masao
Subject [COMMITTERS] pgsql: Don't call the function that may raise an error while holdingsp
Date
Msg-id E1d1Cq3-0002uD-EV@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Don't call the function that may raise an error while holding spinlock.

It's not safe to raise an error while holding spinlock. But previously
logical replication worker for table sync called the function which
reads the system catalog and may raise an error while it's holding
spinlock. Which could lead to the trouble where spinlock will never
be released and the server gets stuck infinitely.

Author: Petr Jelinek
Reviewed-by: Kyotaro Horiguchi and Fujii Masao
Reported-by: Fujii Masao
Discussion: http://postgr.es/m/CAHGQGwFDWh_Qr-q_GEMpD+qH=vYPMdVqw=ZOSY3kX_Pna9R9SA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8bbc618b4825b13a9776f2289acd06483e140300

Modified Files
--------------
src/backend/replication/logical/tablesync.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: [COMMITTERS] pgsql: Fix typo in docs on SASL authentication.
Next
From: Fujii Masao
Date:
Subject: [COMMITTERS] pgsql: Mark some columns in pg_subscription as NOT NULL.