[COMMITTERS] pgsql: Fix pgbench's --progress-timestamp option to print Unix-epochti - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Fix pgbench's --progress-timestamp option to print Unix-epochti
Date
Msg-id E1cxvOe-0001rf-5f@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix pgbench's --progress-timestamp option to print Unix-epoch timestamps.

As a consequence of commit 1d63f7d2d, on platforms with CLOCK_MONOTONIC,
you got some random timescale or other instead of standard Unix timestamps
as expected.  I'd attempted to fix pgbench for that change in commits
74baa1e3b and 67a875355, but missed this place.  Fix in the same way as
those previous commits, ie, just eat the cost of an extra gettimeofday();
one extra syscall per progress report isn't worth sweating over.  Per
report from Jeff Janes.

In passing, use snprintf not sprintf for this purpose.  I don't think
there's any chance of actual buffer overrun, but it just looks safer.

Discussion: https://postgr.es/m/CAMkU=1zrQaPwBN+NcBd3pWCb=vWaiL=mmWfJjDJjh-a7eVr-Og@mail.gmail.com

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/feffa0e0795a5a99324890a6dd548ba162ec104c

Modified Files
--------------
src/bin/pgbench/pgbench.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Michael Meskes
Date:
Subject: [COMMITTERS] pgsql: Document that bytea is best represented as char * in C forecpg.
Next
From: Robert Haas
Date:
Subject: [COMMITTERS] pgsql: Fix possibile deadlock when dropping partitions.