pgsql: Remove dead code and fix comments in fast-path functionhandling - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Remove dead code and fix comments in fast-path functionhandling
Date
Msg-id E1cw0eH-00012M-2q@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove dead code and fix comments in fast-path function handling.

HandleFunctionRequest() is no longer responsible for reading the protocol
message from the client, since commit 2b3a8b20c2. Fix the outdated
comments.

HandleFunctionRequest() now always returns 0, because the code that used
to return EOF was moved in 2b3a8b20c2. Therefore, the caller no longer
needs to check the return value.

Reported by Andres Freund. Backpatch to all supported versions, even though
this doesn't have any user-visible effect, to make backporting future
patches in this area easier.

Discussion: https://www.postgresql.org/message-id/20170405010525.rt5azbya5fkbhvrx@alap3.anarazel.de

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/88101abe70cb81c773cd3102eee6a79ac8f77bfb

Modified Files
--------------
src/backend/tcop/fastpath.c | 22 +++++-----------------
src/backend/tcop/postgres.c | 14 +-------------
src/include/tcop/fastpath.h |  2 +-
3 files changed, 7 insertions(+), 31 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Code review for recent slot.c changes.
Next
From: Simon Riggs
Date:
Subject: [COMMITTERS] pgsql: Avoid SnapshotResetXmin() during AtEOXact_Snapshot()