[COMMITTERS] pgsql: Remove unnecessary dependency on statement_timeout inprepared_x - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Remove unnecessary dependency on statement_timeout inprepared_x
Date
Msg-id E1cnWsJ-0001gh-8t@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove unnecessary dependency on statement_timeout in prepared_xacts test.

Rather than waiting around for statement_timeout to expire, we can just
try to take the table's lock in nowait mode.  This saves some fraction
under 4 seconds when running this test with prepared xacts available,
and it guards against timeout-expired-anyway failures on very slow
machines when prepared xacts are not available, as seen in a recent
failure on axolotl for instance.

This approach could fail if autovacuum were to take an exclusive lock
on the test table concurrently, but there's no reason for it to do so.

Since the main point here is to improve stability in the buildfarm,
back-patch to all supported branches.

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/d999b896d801130da461d55560188e7c4d36819a

Modified Files
--------------
src/test/regress/expected/prepared_xacts.out   | 10 ++++------
src/test/regress/expected/prepared_xacts_1.out | 14 ++------------
src/test/regress/sql/prepared_xacts.sql        |  6 ++----
3 files changed, 8 insertions(+), 22 deletions(-)


pgsql-committers by date:

Previous
From: Michael Meskes
Date:
Subject: [COMMITTERS] pgsql: Document two phase commit commands in ecpg docu.
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Add a "void *" passthrough pointer for psqlscan.l's callbackfun