Remove PL/Tcl's "module" facility.
PL/Tcl has long had a facility whereby Tcl code could be autoloaded from
a database table named "pltcl_modules". However, nobody is using it, as
evidenced by the recent discovery that it's never been fixed to work with
standard_conforming_strings turned on. Moreover, it's rather shaky from
a security standpoint, and the table design is very old and crufty (partly
because it dates from before we had TOAST). A final problem is that
because the table-population scripts depend on the Tcl client library
Pgtcl, which we removed from the core distribution in 2004, it's
impossible to create a self-contained regression test for the feature.
Rather than try to surmount these problems, let's just remove it.
A follow-on patch will provide a way to execute user-defined
initialization code, similar to features that exist in plperl and plv8.
With that, it will be possible to implement this feature or similar ones
entirely in userspace, which is where it belongs.
Discussion: https://postgr.es/m/22067.1488046447@sss.pgh.pa.us
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/817f2a586342767d3289a320bb1dac5dcbb76979
Modified Files
--------------
doc/src/sgml/pltcl.sgml | 45 ----
src/pl/tcl/Makefile | 5 -
src/pl/tcl/modules/.gitignore | 3 -
src/pl/tcl/modules/Makefile | 28 --
src/pl/tcl/modules/README | 18 --
src/pl/tcl/modules/pltcl_delmod.in | 117 ---------
src/pl/tcl/modules/pltcl_listmod.in | 123 ---------
src/pl/tcl/modules/pltcl_loadmod.in | 501 ------------------------------------
src/pl/tcl/modules/unknown.pltcl | 63 -----
src/pl/tcl/pltcl.c | 126 ---------
10 files changed, 1029 deletions(-)
