[COMMITTERS] pgsql: Fix unportable definition of BSWAP64() macro. - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Fix unportable definition of BSWAP64() macro.
Date
Msg-id E1chMN9-0004Nb-KN@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix unportable definition of BSWAP64() macro.

We have a portable way of writing uint64 constants, but whoever wrote
this macro didn't know about it.

While at it, fix unsafe under-parenthesization of arguments.  That might
be moot, because there are already good reasons not to use the macro on
anything more complicated than a simple variable, but it's still poor
practice.

Per buildfarm warnings.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/41c16edcf6c90d1f42810ea523b7e65c99edad50

Modified Files
--------------
src/include/port/pg_bswap.h | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: [COMMITTERS] pgsql: Make tablesample work with partitioned tables.
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Suppress compiler warnings in ecpg test on newer Windowstoolcha