[COMMITTERS] pgsql: Add an Assert that enum_cmp_internal() gets passed an FmgrInfop - Mailing list pgsql-committers

Add an Assert that enum_cmp_internal() gets passed an FmgrInfo pointer.

If someone were to try to call one of the enum comparison functions
using DirectFunctionCallN, it would very likely seem to work, because
only in unusual cases does enum_cmp_internal() need to access the
typcache.  But once such a case occurred, code like that would crash
with a null pointer dereference.  To make an oversight of that sort
less likely to escape detection, add a non-bypassable Assert that
fcinfo->flinfo isn't NULL.

Discussion: https://postgr.es/m/25226.1487900067@sss.pgh.pa.us

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/6d493e1a013514a6f0abb5d30d08219c1831cfec

Modified Files
--------------
src/backend/utils/adt/enum.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)