[COMMITTERS] pgsql: De-support floating-point timestamps. - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: De-support floating-point timestamps.
Date
Msg-id E1cgwRQ-0004BB-OZ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
De-support floating-point timestamps.

Per discussion, the time has come to do this.  The handwriting has been
on the wall at least since 9.0 that this would happen someday, whenever
it got to be too much of a burden to support the float-timestamp option.
The triggering factor now is the discovery that there are multiple bugs
in the code that attempts to implement use of integer timestamps in the
replication protocol even when the server is built for float timestamps.
The internal float timestamps leak into the protocol fields in places.
While we could fix the identified bugs, there's a very high risk of
introducing more.  Trying to build a wall that would positively prevent
mixing integer and float timestamps is more complexity than we want to
undertake to maintain a long-deprecated option.  The fact that these
bugs weren't found through testing also indicates a lack of interest
in float timestamps.

This commit disables configure's --disable-integer-datetimes switch
(it'll still accept --enable-integer-datetimes, though), removes direct
references to USE_INTEGER_DATETIMES, and removes discussion of float
timestamps from the user documentation.  A considerable amount of code is
rendered dead by this, but removing that will occur as separate mop-up.

Discussion: https://postgr.es/m/26788.1487455319@sss.pgh.pa.us

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/b6aa17e0ae367afdcea07118e016111af4fa6bc3

Modified Files
--------------
configure                                          | 18 +++----
configure.in                                       | 12 ++---
doc/src/sgml/config.sgml                           |  8 ++--
doc/src/sgml/datatype.sgml                         | 55 +++++-----------------
doc/src/sgml/installation.sgml                     | 22 ---------
src/include/c.h                                    |  7 +--
src/include/pg_config.h.in                         |  4 --
src/include/pg_config.h.win32                      |  4 --
src/interfaces/ecpg/include/ecpg_config.h.in       |  4 --
src/interfaces/ecpg/include/pgtypes_interval.h     |  2 -
.../ecpg/test/expected/pgtypeslib-dt_test2.c       |  6 +--
.../ecpg/test/expected/pgtypeslib-dt_test2.stdout  |  2 +
src/interfaces/ecpg/test/pgtypeslib/dt_test2.pgc   |  6 +--
src/tools/msvc/Solution.pm                         |  9 ----
src/tools/msvc/config_default.pl                   |  1 -
15 files changed, 36 insertions(+), 124 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: [COMMITTERS] pgsql: Fix logical replication with different encodings
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Remove pg_control's enableIntTimes field.