[COMMITTERS] pgsql: Fix tab completion for "ALTER SYSTEM SET variable ...". - Mailing list pgsql-committers

From Tom Lane
Subject [COMMITTERS] pgsql: Fix tab completion for "ALTER SYSTEM SET variable ...".
Date
Msg-id E1ce66o-00065D-PH@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix tab completion for "ALTER SYSTEM SET variable ...".

It wouldn't complete "TO" after the variable name, which is certainly
minor enough.  But since we do complete "TO" after "SET variable ...",
and since this case used to work pre-9.6, I think this is a bug.

Also, fix the query used to collect the variable names; whoever last
touched it evidently didn't understand how the pieces are supposed
to fit together.  It accidentally worked anyway, because readline
ignores irrelevant completions, but it was randomly unlike the ones
around it, and could be a source of actual bugs if someone copied
it as a prototype for another query.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/a5d4e3ff79636a647a69e93ec8b9239703e9556a

Modified Files
--------------
src/bin/psql/tab-complete.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Fix YA unwanted behavioral difference withoperator_precedence_w
Next
From: Tom Lane
Date:
Subject: [COMMITTERS] pgsql: Doc: fix syntax synopsis for INSERT ... ON CONFLICT DO UPDATE.