[COMMITTERS] pgsql: Make dblink try harder to form useful error messages - Mailing list pgsql-committers

From Joe Conway
Subject [COMMITTERS] pgsql: Make dblink try harder to form useful error messages
Date
Msg-id E1cK7Ua-0001S3-Kg@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make dblink try harder to form useful error messages

When libpq encounters a connection-level error, e.g. runs out of memory
while forming a result, there will be no error associated with PGresult,
but a message will be placed into PGconn's error buffer. postgres_fdw
takes care to use the PGconn error message when PGresult does not have
one, but dblink has been negligent in that regard. Modify dblink to mirror
what postgres_fdw has been doing.

Back-patch to all supported branches.

Author: Joe Conway
Reviewed-By: Tom Lane
Discussion: https://postgr.es/m/02fa2d90-2efd-00bc-fefc-c23c00eb671e%40joeconway.com

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/9b8507bfae9119427a5c3acf037c466a7e3d7046

Modified Files
--------------
contrib/dblink/dblink.c | 31 ++++++++++++++++++++++---------
1 file changed, 22 insertions(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Joe Conway
Date:
Subject: [COMMITTERS] pgsql: Make dblink try harder to form useful error messages
Next
From: Joe Conway
Date:
Subject: [COMMITTERS] pgsql: Make dblink try harder to form useful error messages