pgsql: Fix unsafe assumption that struct timeval.tv_sec is a "long". - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix unsafe assumption that struct timeval.tv_sec is a "long".
Date
Msg-id E1cEQTd-0008Dd-C9@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix unsafe assumption that struct timeval.tv_sec is a "long".

It typically is a "long", but it seems possible that on some platforms
it wouldn't be.  In any case, this silences a compiler warning on
OpenBSD (cf buildfarm member curculio).

While at it, use snprintf not sprintf.  This format string couldn't
possibly overrun the supplied buffer, but that doesn't seem like
a good reason not to use the safer style.

Oversight in commit f828654e1.  Back-patch to 9.6 where that came in.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/0645dacc371da6169b06934e3bd238c5f770fe25

Modified Files
--------------
src/backend/utils/error/elog.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Put AC_MSG_RESULT() call in the right place.
Next
From: Tom Lane
Date:
Subject: pgsql: Fix unsafe assumption that struct timeval.tv_sec is a "long".