pgsql: Remove wrong CloseHandle() call. - Mailing list pgsql-committers

From Noah Misch
Subject pgsql: Remove wrong CloseHandle() call.
Date
Msg-id E1cDHKr-0003iJ-Mo@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove wrong CloseHandle() call.

In accordance with its own documentation, invoke CloseHandle() only when
directed in the documentation for the function that furnished the
handle.  GetModuleHandle() does not so direct.  We have been issuing
this call only in the rare event that a CRT DLL contains no "_putenv"
symbol, so lack of bug reports is uninformative.  Back-patch to 9.2 (all
supported versions).

Christian Ullrich, reviewed by Michael Paquier.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/ec7eacfae271a454e6ad01ea0f710dc71e1d9852

Modified Files
--------------
src/port/win32env.c | 1 -
1 file changed, 1 deletion(-)


pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: pgsql: Make pgwin32_putenv() visit debug CRTs.
Next
From: Noah Misch
Date:
Subject: pgsql: Make pgwin32_putenv() follow DLL loading and unloading.