pgsql: Delete contrib/xml2's legacy implementation of xml_is_well_forme - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Delete contrib/xml2's legacy implementation of xml_is_well_forme
Date
Msg-id E1c2n0C-0004UI-Ml@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Delete contrib/xml2's legacy implementation of xml_is_well_formed().

This function is unreferenced in modern usage; it was superseded in 9.1
by a core function of the same name.  It has been left in place in the C
code only so that pre-9.1 SQL definitions of the contrib/xml2 functions
would continue to work.  Six years seems like enough time for people to
have updated to the extension-style version of the xml2 module, so let's
drop this.

The key reason for not keeping it any longer is that we want to stick
an explicit PGDLLEXPORT into PG_FUNCTION_INFO_V1(), and the similarity
of name to the core function creates a conflict that compilers will
complain about.

Extracted from a larger patch for that purpose.  I'm committing this
change separately to give it more visibility in the commit logs.

While at it, remove the documentation entry that claimed that
xml_is_well_formed() is a function provided by contrib/xml2, and
instead mention the even more ancient alias xml_valid().

Laurenz Albe, doc change by me

Patch: <A737B7A37273E048B164557ADEF4A58B53962ED8@ntex2010a.host.magwien.gv.at>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/20540710e83f2873707c284a0c0693f0b57156c4

Modified Files
--------------
contrib/xml2/xpath.c   | 45 ---------------------------------------------
doc/src/sgml/xml2.sgml | 10 +++++-----
2 files changed, 5 insertions(+), 50 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Be more consistent about masking xl_info with ~XLR_INFO_MASK.
Next
From: Tom Lane
Date:
Subject: pgsql: Provide DLLEXPORT markers for C functions via PG_FUNCTION_INFO_V