pgsql: Fix incorrect trigger-property updating in ALTER CONSTRAINT. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix incorrect trigger-property updating in ALTER CONSTRAINT.
Date
Msg-id E1bzVO2-0006YC-Vv@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix incorrect trigger-property updating in ALTER CONSTRAINT.

The code to change the deferrability properties of a foreign-key constraint
updated all the associated triggers to match; but a moment's examination of
the code that creates those triggers in the first place shows that only
some of them should track the constraint's deferrability properties.  This
leads to odd failures in subsequent exercise of the foreign key, as the
triggers are fired at the wrong times.  Fix that, and add a regression test
comparing the trigger properties produced by ALTER CONSTRAINT with those
you get by creating the constraint as-intended to begin with.

Per report from James Parks.  Back-patch to 9.4 where this ALTER
functionality was introduced.

Report: <CAJ3Xv+jzJ8iNNUcp4RKW8b6Qp1xVAxHwSXVpjBNygjKxcVuE9w@mail.gmail.com>

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/b53c841e5e289a34fde848d44b3d0b2b0ed5cad8

Modified Files
--------------
src/backend/commands/tablecmds.c          | 31 +++++++++++++---
src/test/regress/expected/alter_table.out | 60 +++++++++++++++++++++++++++++++
src/test/regress/sql/alter_table.sql      | 33 +++++++++++++++++
3 files changed, 119 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix incorrect trigger-property updating in ALTER CONSTRAINT.
Next
From: Bruce Momjian
Date:
Subject: pgsql: Properly indent postgresql.conf comments to align