pgsql: Only treat Python Lists as array dimensions. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject pgsql: Only treat Python Lists as array dimensions.
Date
Msg-id E1bzMe1-00054l-Ed@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Only treat Python Lists as array dimensions.

Instead of treating all python sequence types as array dimensions, except
for tuples and various kinds of strings, only treat Python lists as
dimensions. The PyBytes_Check() function used previously is only available
on Python 2.6 and newer, and it was a bit fiddly anyway. The list of
exceptions would require adjustment if Python got a new kind of a sequence
similar to bytes/unicodes/strings, so only checking for Lists seems more
future-proof. The documentation only mentioned using Lists, so this is
closer to what was documented, anyway.

This should fix the buildfarm failures on systems building with Python 2.5,
although I don't have Python 2.5 installed myself to test with.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cfd9c87a54b0d414a59a912710c6633313174e51

Modified Files
--------------
src/pl/plpython/plpy_typeio.c | 10 +---------
1 file changed, 1 insertion(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Avoid using platform-dependent floats in test case.
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Avoid using platform-dependent floats in test case.