pgsql: Try to find out the actual hugepage size when making a MAP_HUGET - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Try to find out the actual hugepage size when making a MAP_HUGET
Date
Msg-id E1bulLn-0005hR-0q@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Try to find out the actual hugepage size when making a MAP_HUGETLB request.

Even if Linux's mmap() is okay with a partial-hugepage request, munmap()
is not, as reported by Chris Richards.  Therefore it behooves us to try
a bit harder to find out the actual hugepage size, instead of assuming
that we can skate by with a guess.

For the moment, just look into /proc/meminfo to find out the default
hugepage size, and use that.  Later, on kernels that support requests
for nondefault sizes, we might try to consider other alternatives.
But that smells more like a new feature than a bug fix, especially if
we want to provide any way for the DBA to control it, so leave it for
another day.

I set this up to allow easy addition of platform-specific code for
non-Linux platforms, if needed; but right now there are no reports
suggesting that we need to work harder on other platforms.

Back-patch to 9.4 where hugepage support was introduced.

Discussion: <31056.1476303954@sss.pgh.pa.us>

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/43d17489d112e19bb51ae418bd3d63cb062afd62

Modified Files
--------------
src/backend/port/sysv_shmem.c | 97 ++++++++++++++++++++++++++++++++++++-------
1 file changed, 81 insertions(+), 16 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Try to find out the actual hugepage size when making a MAP_HUGET
Next
From: Tom Lane
Date:
Subject: pgsql: Remove dead code in pg_dump.