pgsql: Retry DSM control segment creation if Windows indicates access d - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Retry DSM control segment creation if Windows indicates access d
Date
Msg-id E1bmNgq-00075V-RG@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Retry DSM control segment creation if Windows indicates access denied.

Otherwise, attempts to run multiple postmasters running on the same
machine may fail, because Windows sometimes returns ERROR_ACCESS_DENIED
rather than ERROR_ALREADY_EXISTS when there is an existing segment.

Hitting this bug is much more likely because of another defect not
fixed by this patch, namely that dsm_postmaster_startup() uses
random() which returns the same value every time.  But that's not
a reason not to fix this.

Kyotaro Horiguchi and Amit Kapila, reviewed by Michael Paquier

Discussion: <CAA4eK1JyNdMeF-dgrpHozDecpDfsRZUtpCi+1AbtuEkfG3YooQ@mail.gmail.com>

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/c124e3649b0423cd7abc3f81208d9c7e8a7e8a8a

Modified Files
--------------
src/backend/storage/ipc/dsm_impl.c | 31 ++++++++++++++++++-------------
1 file changed, 18 insertions(+), 13 deletions(-)


pgsql-committers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: pgsql: Fix outdated comments, GIST search queue is not an RBTree anymor
Next
From: Robert Haas
Date:
Subject: pgsql: Retry DSM control segment creation if Windows indicates access d