pgsql: Prevent starting a standalone backend with standby_mode on. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Prevent starting a standalone backend with standby_mode on.
Date
Msg-id E1bf50O-0003ir-QY@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Prevent starting a standalone backend with standby_mode on.

This can't really work because standby_mode expects there to be more
WAL arriving, which there will not ever be because there's no WAL
receiver process to fetch it.  Moreover, if standby_mode is on then
hot standby might also be turned on, causing even more strangeness
because that expects read-only sessions to be executing in parallel.
Bernd Helmle reported a case where btree_xlog_delete_get_latestRemovedXid
got confused, but rather than band-aiding individual problems it seems
best to prevent getting anywhere near this state in the first place.
Back-patch to all supported branches.

In passing, also fix some omissions of errcodes in other ereport's in
readRecoveryCommandFile().

Michael Paquier (errcode hacking by me)

Discussion: <00F0B2CEF6D0CEF8A90119D4@eje.credativ.lan>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/0e0f43d6fdc2e1fbd5261245ed4cf85302a3f653

Modified Files
--------------
src/backend/access/transam/xlog.c | 24 +++++++++++++++++++-----
1 file changed, 19 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Update comments to reflect code rearrangement.
Next
From: Tom Lane
Date:
Subject: pgsql: Prevent starting a standalone backend with standby_mode on.