pgsql: reorderbuffer: preserve errno while reporting error - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: reorderbuffer: preserve errno while reporting error
Date
Msg-id E1banmJ-0008W4-OQ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
reorderbuffer: preserve errno while reporting error

Clobbering errno during cleanup after an error is an oft-repeated, easy
to make mistake.  Deal with it here as everywhere else, by saving it
aside and restoring after cleanup, before ereport'ing.

In passing, add a missing errcode declaration in another ereport() call
in the same file, which I noticed while skimming the file looking for
similar problems.

Backpatch to 9.4, where this code was introduced.

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/ac3aac3292d6e958bb8235120ba6a12159a29afe

Modified Files
--------------
src/backend/replication/logical/reorderbuffer.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Clean up another pre-ANSI-C-ism in regex code: get rid of pcolor
Next
From: Alvaro Herrera
Date:
Subject: pgsql: reorderbuffer: preserve errno while reporting error