pgsql: Fix inappropriate printing of never-measured times in EXPLAIN. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix inappropriate printing of never-measured times in EXPLAIN.
Date
Msg-id E1bYF5H-0001oL-RP@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix inappropriate printing of never-measured times in EXPLAIN.

EXPLAIN (ANALYZE, TIMING OFF) would print an elapsed time of zero for
a trigger function, because no measurement has been taken but it printed
the field anyway.  This isn't what EXPLAIN does elsewhere, so suppress it.

In the same vein, EXPLAIN (ANALYZE, BUFFERS) with non-text output format
would print buffer I/O timing numbers even when no measurement has been
taken because track_io_timing is off.  That seems not per policy, either,
so change it.

Back-patch to 9.2 where these features were introduced.

Maksim Milyutin

Discussion: <081c0540-ecaa-bd29-3fd2-6358f3b359a9@postgrespro.ru>

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/ed2d7b8c8ce53648a0ef1c3fc5e99bd69b17dfca

Modified Files
--------------
src/backend/commands/explain.c | 18 +++++++++++++-----
1 file changed, 13 insertions(+), 5 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix inappropriate printing of never-measured times in EXPLAIN.
Next
From: Tom Lane
Date:
Subject: pgsql: Doc: clarify that DROP ... CASCADE is recursive.