Obstruct shell, SQL, and conninfo injection via database and role names.
Due to simplistic quoting and confusion of database names with conninfo
strings, roles with the CREATEDB or CREATEROLE option could escalate to
superuser privileges when a superuser next ran certain maintenance
commands. The new coding rule for PQconnectdbParams() calls, documented
at conninfo_array_parse(), is to pass expand_dbname=true and wrap
literal database names in a trivial connection string. Escape
zero-length values in appendConnStrVal(). Back-patch to 9.1 (all
supported versions).
Nathan Bossart, Michael Paquier, and Noah Misch. Reviewed by Peter
Eisentraut. Reported by Nathan Bossart.
Security: CVE-2016-5424
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/fcd15f13581f6d75c63d213220d5a94889206c1b
Modified Files
--------------
src/bin/pg_basebackup/streamutil.c | 12 +++++--
src/bin/pg_dump/pg_backup.h | 4 +--
src/bin/pg_dump/pg_backup_archiver.c | 34 +++++++++++++-----
src/bin/pg_dump/pg_backup_db.c | 10 +++++-
src/bin/pg_dump/pg_dumpall.c | 18 +++++++---
src/bin/pg_upgrade/Makefile | 3 +-
src/bin/pg_upgrade/check.c | 19 ++++++----
src/bin/pg_upgrade/dump.c | 16 +++++++--
src/bin/pg_upgrade/pg_upgrade.c | 16 +++++++--
src/bin/pg_upgrade/server.c | 51 +++++++++++++++++----------
src/bin/pg_upgrade/test.sh | 17 +++++++++
src/bin/pg_upgrade/version.c | 11 ++++--
src/bin/psql/command.c | 15 +++++++-
src/bin/scripts/clusterdb.c | 10 +++++-
src/bin/scripts/reindexdb.c | 14 ++++++--
src/bin/scripts/vacuumdb.c | 17 +++++----
src/fe_utils/string_utils.c | 67 ++++++++++++++++++++++++++++++++++--
src/include/fe_utils/string_utils.h | 1 +
src/interfaces/libpq/fe-connect.c | 6 +++-
src/tools/msvc/vcregress.pl | 41 ++++++++++++++++++++++
20 files changed, 315 insertions(+), 67 deletions(-)
