pgsql: Fix bogus coding in WaitForBackgroundWorkerShutdown(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix bogus coding in WaitForBackgroundWorkerShutdown().
Date
Msg-id E1bVOuP-0005eZ-6V@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix bogus coding in WaitForBackgroundWorkerShutdown().

Some conditions resulted in "return" directly out of a PG_TRY block,
which left the exception stack dangling, and to add insult to injury
failed to restore the state of set_latch_on_sigusr1.

This is a bug only in 9.5; in HEAD it was accidentally fixed by commit
db0f6cad4, which removed the surrounding PG_TRY block.  However, I (tgl)
chose to apply the patch to HEAD as well, because the old coding was
gratuitously different from WaitForBackgroundWorkerStartup(), and there
would indeed have been no bug if it were done like that to start with.

Dmitry Ivanov

Discussion: <1637882.WfYN5gPf1A@abook>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/8d498a5c8a4c702ca71463a5c76bb4f319872378

Modified Files
--------------
src/backend/postmaster/bgworker.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix bogus coding in WaitForBackgroundWorkerShutdown().
Next
From: Bruce Momjian
Date:
Subject: pgsql: docs: mention rsync of temp and unlogged tables