pgsql: Make "postgres -C guc" print "" not "(null)" for null-valued GUC - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Make "postgres -C guc" print "" not "(null)" for null-valued GUC
Date
Msg-id E1bFkVi-00047Y-JQ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make "postgres -C guc" print "" not "(null)" for null-valued GUCs.

Commit 0b0baf262 et al made this case print "(null)" on the grounds that
that's what happened on platforms that didn't crash.  But neither behavior
was actually intentional.  What we should print is just an empty string,
for compatibility with the behavior of SHOW and other ways of examining
string GUCs.  Those code paths don't distinguish NULL from empty strings,
so we should not here either.  Per gripe from Alain Radix.

Like the previous patch, back-patch to 9.2 where -C option was introduced.

Discussion: <CA+YdpwxPUADrmxSD7+Td=uOshMB1KkDN7G7cf+FGmNjjxMhjbw@mail.gmail.com>

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/f2c28bb1f2fee6fa33d2d6d4316b3f1d499543a4

Modified Files
--------------
src/backend/postmaster/postmaster.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Improve cleanup in rolenames test
Next
From: Tom Lane
Date:
Subject: pgsql: Make "postgres -C guc" print "" not "(null)" for null-valued GUC