pgsql: Remove pg_dump/parallel.c's useless "aborting" flag. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Remove pg_dump/parallel.c's useless "aborting" flag.
Date
Msg-id E1b744f-0005uQ-29@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Remove pg_dump/parallel.c's useless "aborting" flag.

This was effectively dead code, since the places that tested it could not
be reached after we entered the on-exit-cleanup routine that would set it.
It seems to have been a leftover from a design in which error abort would
try to send fresh commands to the workers --- a design which could never
have worked reliably, of course.  Since the flag is not cross-platform, it
complicates reasoning about the code's behavior, which we could do without.

Although this is effectively just cosmetic, back-patch anyway, because
there are some actual bugs in the vicinity of this behavior.

Discussion: <15583.1464462418@sss.pgh.pa.us>

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/937b85805b6e87180bf9e088acfb4ba4e3e3d9bc

Modified Files
--------------
src/bin/pg_dump/parallel.c | 34 ++++++----------------------------
1 file changed, 6 insertions(+), 28 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Lots of comment-fixing, and minor cosmetic cleanup, in pg_dump/p
Next
From: Tom Lane
Date:
Subject: pgsql: Remove pg_dump/parallel.c's useless "aborting" flag.