pgsql: Make pg_dump behave more sanely when built without HAVE_LIBZ. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Make pg_dump behave more sanely when built without HAVE_LIBZ.
Date
Msg-id E1b5xZY-0001iS-5a@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Make pg_dump behave more sanely when built without HAVE_LIBZ.

For some reason the code to emit a warning and switch to uncompressed
output was placed down in the guts of pg_backup_archiver.c.  This is
definitely too late in the case of parallel operation (and I rather
wonder if it wasn't too late for other purposes as well).  Put it in
pg_dump.c's option-processing logic, which seems a much saner place.

Also, the default behavior with custom or directory output format was
to emit the warning telling you the output would be uncompressed.  This
seems unhelpful, so silence that case.

Back-patch to 9.3 where parallel dump was introduced.

Kyotaro Horiguchi, adjusted a bit by me

Report: <20160526.185551.242041780.horiguchi.kyotaro@lab.ntt.co.jp>

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/cae2bb1986bc8fd409424562638434d588d0201f

Modified Files
--------------
src/bin/pg_dump/pg_backup_archiver.c | 10 ----------
src/bin/pg_dump/pg_dump.c            |  9 +++++++++
2 files changed, 9 insertions(+), 10 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Make pg_dump behave more sanely when built without HAVE_LIBZ.
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Fix typo in 9.5 release nodes