pgsql: In Windows pg_dump, ensure idle workers will shut down during er - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: In Windows pg_dump, ensure idle workers will shut down during er
Date
Msg-id E1b5wcm-0000MM-83@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
In Windows pg_dump, ensure idle workers will shut down during error exit.

The Windows coding of ShutdownWorkersHard() thought that setting termEvent
was sufficient to make workers exit after an error.  But that only helps
if a worker is busy and passes through checkAborting().  An idle worker
will just sit, resulting in pg_dump failing to exit until the user gives up
and hits control-C.  We should close the write end of the command pipe
so that idle workers will see socket EOF and exit, as the Unix coding was
already doing.

Back-patch to 9.3 where parallel pg_dump was introduced.

Kyotaro Horiguchi

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/b9784e1f769497dcfaa1f866913f3d86a2adf176

Modified Files
--------------
src/bin/pg_dump/parallel.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: In Windows pg_dump, ensure idle workers will shut down during er
Next
From: Tom Lane
Date:
Subject: pgsql: In Windows pg_dump, ensure idle workers will shut down during er