pgsql: Qualify table usage in dumpTable() and use regclass - Mailing list pgsql-committers

From Stephen Frost
Subject pgsql: Qualify table usage in dumpTable() and use regclass
Date
Msg-id E1b5MP0-0008CL-TA@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Qualify table usage in dumpTable() and use regclass

All of the other tables used in the query in dumpTable(), which is
collecting column-level ACLs, are qualified, so we should be qualifying
the pg_init_privs, the related sub-select against pg_class and the
other queries added by the pg_dump catalog ACLs work.

Also, use ::regclass (or ::pg_catalog.regclass, where appropriate)
instead of using a poorly constructed query to get the OID for various
catalog tables.

Issues identified by Noah and Alvaro, patch by me.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/2e8b4bf80473d0e4a4254b417424e79195a9ce6a

Modified Files
--------------
src/bin/pg_dump/dumputils.c                 | 24 +++++------
src/bin/pg_dump/pg_dump.c                   | 67 +++++++++++++++--------------
src/test/modules/test_pg_dump/t/001_base.pl |  8 ++--
3 files changed, 50 insertions(+), 49 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [HACKERS] Re: pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <
Next
From: Tom Lane
Date:
Subject: pgsql: Fix contrib/bloom to work for unlogged indexes.