pgsql: Avoid possible crash in contrib/bloom's blendscan(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Avoid possible crash in contrib/bloom's blendscan().
Date
Msg-id E1b2m7I-0007sk-BP@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Avoid possible crash in contrib/bloom's blendscan().

It's possible to begin and end an indexscan without ever calling
amrescan.  contrib/bloom, unlike every other index AM, allocated
its "scan->opaque" storage at amrescan time, and thus would crash
in amendscan if amrescan hadn't been called.  We could fix this
by putting in a null-pointer check in blendscan, but I see no very
good reason why contrib/bloom should march to its own drummer in
this respect.  Let's move that initialization to blbeginscan
instead.  Per report from Jeff Janes.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/e13ac5586c49c77f301329b79bd7e8f489d0e66f

Modified Files
--------------
contrib/bloom/blscan.c | 26 ++++++++++----------------
1 file changed, 10 insertions(+), 16 deletions(-)


pgsql-committers by date:

Previous
From: Teodor Sigaev
Date:
Subject: Re: pgsql: Allocate all page images at once in generic wal interface
Next
From: Tom Lane
Date:
Subject: pgsql: Pin the built-in index access methods.