pgsql: Disable abbreviated keys for string-sorting in non-C locales. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Disable abbreviated keys for string-sorting in non-C locales.
Date
Msg-id E1aip3e-000671-Ch@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Disable abbreviated keys for string-sorting in non-C locales.

Unfortunately, every version of glibc thus far tested has bugs whereby
strcoll() ordering does not match strxfrm() ordering as required by
the standard.  This can result in, for example, corrupted indexes.
Disabling abbreviated keys in these cases slows down non-C-collation
string sorting considerably, but there seems to be no practical
alternative.  Users who are confident that their libc implementations
are solid in this regard can re-enable the optimization by compiling
with TRUST_STRXFRM.

Users who have built indexes using PostgreSQL 9.5 or PostgreSQL 9.5.1
should REINDEX if there is a possibility that they may have been
affected by this problem.

Report by Marc-Olaf Jaschke.  Investigation mostly by Tom Lane, with
help from Peter Geoghegan, Noah Misch, Stephen Frost, and me.  Patch
by me, reviewed by Peter Geoghegan and Tom Lane.

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/8aa6e97805a79eb30ac9c36acb1126280c2ffbdf

Modified Files
--------------
src/backend/utils/adt/varlena.c | 33 +++++++++++++++++++++++----------
1 file changed, 23 insertions(+), 10 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Disable abbreviated keys for string-sorting in non-C locales.
Next
From: Tom Lane
Date:
Subject: pgsql: Move keywords.c/kwlookup.c into src/common/.