Postgres Pro
Downloads
Home   >   mailing lists

pgsql: Code review for error reports in jsonb_set(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Code review for error reports in jsonb_set().
Date
Msg-id E1aikHD-0001Lr-Ju@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Tree view 
Code review for error reports in jsonb_set().

User-facing (even tested by regression tests) error conditions were thrown
with elog(), hence had wrong SQLSTATE and were untranslatable.  And the
error message texts weren't up to project style, either.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/ea4b8bd6188ecb17ba37d93f57b8b020a964e66c

Modified Files
--------------
src/backend/utils/adt/jsonfuncs.c   | 24 ++++++++++++++----------
src/test/regress/expected/jsonb.out | 12 ++++++------
2 files changed, 20 insertions(+), 16 deletions(-)

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix unsafe use of strtol() on a non-null-terminated Text datum.
Next
From: Tom Lane
Date:
Subject: pgsql: Code review for error reports in jsonb_set().