pgsql: Department of second thoughts: remove PD_ALL_FROZEN. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Department of second thoughts: remove PD_ALL_FROZEN.
Date
Msg-id E1adI73-0007YJ-5c@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Department of second thoughts: remove PD_ALL_FROZEN.

Commit a892234f830e832110f63fc0a2afce2fb21d1584 added a second bit per
page to the visibility map, which still seems like a good idea, but it
also added a second page-level bit alongside PD_ALL_VISIBLE to track
whether the visibility map bit was set.  That no longer seems like a
clever plan, because we don't really need that bit for anything.  We
always clear both bits when the page is modified anyway.

Patch by me, reviewed by Kyotaro Horiguchi and Masahiko Sawada.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/77a1d1e79892a20ed15a67be42b96949b8546bf6

Modified Files
--------------
src/backend/access/heap/heapam.c        |  5 +----
src/backend/access/heap/visibilitymap.c | 33 +++++++++++++++------------------
src/backend/commands/vacuumlazy.c       | 17 +++--------------
src/include/storage/bufpage.h           | 11 ++---------
4 files changed, 21 insertions(+), 45 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Add pg_visibility contrib module.
Next
From: Robert Haas
Date:
Subject: pgsql: Add some functions to fd.c for the convenience of extensions.