pgsql: Fix enforcement of restrictions inside regexp lookaround constra - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix enforcement of restrictions inside regexp lookaround constra
Date
Msg-id E1Zv7Wn-0000Zy-JT@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix enforcement of restrictions inside regexp lookaround constraints.

Lookahead and lookbehind constraints aren't allowed to contain backrefs,
and parentheses within them are always considered non-capturing.  Or so
says the manual.  But the regexp parser forgot about these rules once
inside a parenthesized subexpression, so that constructs like (\w)(?=(\1))
were accepted (but then not correctly executed --- a case like this acted
like (\w)(?=\w), without any enforcement that the two \w's match the same
text).  And in (?=((foo))) the innermost parentheses would be counted as
capturing parentheses, though no text would ever be captured for them.

To fix, properly pass down the "type" argument to the recursive invocation
of parse().

Back-patch to all supported branches; it was agreed that silent
misexecution of such patterns is worse than throwing an error, even though
new errors in minor releases are generally not desirable.

Branch
------
REL9_4_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/f69c01f2c2b7dcd1b584ac1025d4739636a6cc83

Modified Files
--------------
src/backend/regex/regcomp.c         |    2 +-
src/test/regress/expected/regex.out |    5 +++++
src/test/regress/sql/regex.sql      |    4 ++++
3 files changed, 10 insertions(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix enforcement of restrictions inside regexp lookaround constra
Next
From: Kevin Grittner
Date:
Subject: Re: pgsql: Modify tqueue infrastructure to support transient record types.