pgsql: Eschew "RESET statement_timeout" in tests. - Mailing list pgsql-committers

From Noah Misch
Subject pgsql: Eschew "RESET statement_timeout" in tests.
Date
Msg-id E1ZoOjA-0005O8-3j@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Eschew "RESET statement_timeout" in tests.

Instead, use transaction abort.  Given an unlucky bout of latency, the
timeout would cancel the RESET itself.  Buildfarm members gharial,
lapwing, mereswine, shearwater, and sungazer witness that.  Back-patch
to 9.1 (all supported versions).  The query_canceled test still could
timeout before entering its subtransaction; for whatever reason, that
has yet to happen on the buildfarm.

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/01a96c77d638aad0d9d5b040ed62248481d3b5a0

Modified Files
--------------
src/test/regress/expected/plpgsql.out          |   43 ++++++++++++++++--------
src/test/regress/expected/prepared_xacts.out   |    6 ++--
src/test/regress/expected/prepared_xacts_1.out |    6 ++--
src/test/regress/sql/plpgsql.sql               |   37 +++++++++++++-------
src/test/regress/sql/prepared_xacts.sql        |    6 ++--
5 files changed, 65 insertions(+), 33 deletions(-)


pgsql-committers by date:

Previous
From: Noah Misch
Date:
Subject: pgsql: Eschew "RESET statement_timeout" in tests.
Next
From: Noah Misch
Date:
Subject: pgsql: Eschew "RESET statement_timeout" in tests.