pgsql: Rewrite interaction of parallel mode with parallel executor supp - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Rewrite interaction of parallel mode with parallel executor supp
Date
Msg-id E1Zn7N3-0001pS-28@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Rewrite interaction of parallel mode with parallel executor support.

In the previous coding, before returning from ExecutorRun, we'd shut
down all parallel workers.  This was dead wrong if ExecutorRun was
called with a non-zero tuple count; it had the effect of truncating
the query output.  To fix, give ExecutePlan control over whether to
enter parallel mode, and have it refuse to do so if the tuple count
is non-zero.  Rewrite the Gather logic so that it can cope with being
called outside parallel mode.

Commit 7aea8e4f2daa4b39ca9d1309a0c4aadb0f7ed81b is largely to blame
for this problem, though this patch modifies some subsequently-committed
code which relied on the guarantees it purported to make.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/bfc78d7196eb28cd4e3d6c24f7e607bacecf1129

Modified Files
--------------
src/backend/executor/execMain.c     |   37 +++++++-----
src/backend/executor/execParallel.c |   17 ++++++
src/backend/executor/nodeGather.c   |  108 +++++++++++++++++------------------
src/include/executor/execParallel.h |    1 +
src/include/nodes/execnodes.h       |    2 +-
5 files changed, 95 insertions(+), 70 deletions(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Mark more functions parallel-restricted or parallel-unsafe.
Next
From: Robert Haas
Date:
Subject: pgsql: Prohibit parallel query when the isolation level is serializable