pgsql: Fix pg_dump to handle inherited NOT VALID check constraints corr - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix pg_dump to handle inherited NOT VALID check constraints corr
Date
Msg-id E1ZhkLA-0004yl-AJ@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix pg_dump to handle inherited NOT VALID check constraints correctly.

This case seems to have been overlooked when unvalidated check constraints
were introduced, in 9.2.  The code would attempt to dump such constraints
over again for each child table, even though adding them to the parent
table is sufficient.

In 9.2 and 9.3, also fix contrib/pg_upgrade/Makefile so that the "make
clean" target fully cleans up after a failed test.  This evidently got
dealt with at some point in 9.4, but it wasn't back-patched.  I ran into
it while testing this fix ...

Per bug #13656 from Ingmar Brouns.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/7e1e1c9d18c4d2d0b6cc64c697f6af043aac7f36

Modified Files
--------------
contrib/pg_upgrade/Makefile               |    4 +++-
src/bin/pg_dump/pg_dump.c                 |    4 ++--
src/test/regress/expected/alter_table.out |   13 +++++++++++++
src/test/regress/sql/alter_table.sql      |    4 ++++
4 files changed, 22 insertions(+), 3 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Fix commit_ts for standby
Next
From: Tom Lane
Date:
Subject: pgsql: Fix pg_dump to handle inherited NOT VALID check constraints corr