pgsql: Avoid O(N^2) behavior when enlarging SPI tuple table in spi_prin - Mailing list pgsql-committers

Avoid O(N^2) behavior when enlarging SPI tuple table in spi_printtup().

For no obvious reason, spi_printtup() was coded to enlarge the tuple
pointer table by just 256 slots at a time, rather than doubling the size at
each reallocation, as is our usual habit.  For very large SPI results, this
makes for O(N^2) time spent in repalloc(), which of course soon comes to
dominate the runtime.  Use the standard doubling approach instead.

This is a longstanding performance bug, so back-patch to all active
branches.

Neil Conway

Branch
------
REL9_2_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/d951d6065dbf11cca35fd1f7741156d0c55dcd7e

Modified Files
--------------
src/backend/executor/spi.c |    3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)