pgsql: Fix `make installcheck` for serializable transactions. - Mailing list pgsql-committers

From Kevin Grittner
Subject pgsql: Fix `make installcheck` for serializable transactions.
Date
Msg-id E1ZNNRl-0003SB-OA@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix `make installcheck` for serializable transactions.

Commit e5550d5fec66aa74caad1f79b79826ec64898688 added some new
tests for ALTER TABLE which involved table scans.  When
default_transaction_isolation = 'serializable' these acquire
relation-level SIReadLocks.  The test results didn't cope with
that.  Add SIReadLock as the minimum lock level for purposes of
these tests.

This could also be fixed by excluding this type of lock from the
my_locks view, but it would be a bug for SIReadLock to show up for
a relation which was not otherwise locked, so do it this way to
allow that sort of condition to cause a regression test failure.

There is some question whether we could avoid taking SIReadLocks
during these operations, but confirming the safety of that and
figuring out how to avoid the locks is not trivial, and would be
a separate patch.

Backpatch to 9.4 where the new tests were added.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/253de7e1eb9abbcf57e6c229a8a38abd6455c7de

Modified Files
--------------
src/test/regress/expected/alter_table.out |    3 ++-
src/test/regress/sql/alter_table.sql      |    3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Improve includes introduced in the replication origins patch.
Next
From: Kevin Grittner
Date:
Subject: pgsql: Fix `make installcheck` for serializable transactions.