pgsql: Cap wal_buffers to avoid a server crash when it's set very large - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Cap wal_buffers to avoid a server crash when it's set very large
Date
Msg-id E1ZMfmX-0000cn-1c@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Cap wal_buffers to avoid a server crash when it's set very large.

It must be possible to multiply wal_buffers by XLOG_BLCKSZ without
overflowing int, or calculations in StartupXLOG will go badly wrong
and crash the server.  Avoid that by imposing a maximum value on
wal_buffers.  This will be just under 2GB, assuming the usual value
for XLOG_BLCKSZ.

Josh Berkus, per an analysis by Andrew Gierth.

Branch
------
REL9_0_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/b09446ed7eecc7cee6f7cc1dcc954c75c6c7570b

Modified Files
--------------
src/backend/utils/misc/guc.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Cap wal_buffers to avoid a server crash when it's set very large
Next
From: Tom Lane
Date:
Subject: pgsql: Fix a PlaceHolderVar-related oversight in star-schema planning p