pgsql: Cap wal_buffers to avoid a server crash when it's set very large - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Cap wal_buffers to avoid a server crash when it's set very large
Date
Msg-id E1ZMfkG-0000bJ-Bs@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Cap wal_buffers to avoid a server crash when it's set very large.

It must be possible to multiply wal_buffers by XLOG_BLCKSZ without
overflowing int, or calculations in StartupXLOG will go badly wrong
and crash the server.  Avoid that by imposing a maximum value on
wal_buffers.  This will be just under 2GB, assuming the usual value
for XLOG_BLCKSZ.

Josh Berkus, per an analysis by Andrew Gierth.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/369342cf70972a81e6be99b31593f31b73479d7f

Modified Files
--------------
src/backend/utils/misc/guc.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Cap wal_buffers to avoid a server crash when it's set very large
Next
From: Robert Haas
Date:
Subject: pgsql: Cap wal_buffers to avoid a server crash when it's set very large