pgsql: Reduce chatter from signaling of autovacuum workers. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Reduce chatter from signaling of autovacuum workers.
Date
Msg-id E1ZKCWA-0006RA-UG@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Reduce chatter from signaling of autovacuum workers.

Don't print a WARNING if we get ESRCH from a kill() that's attempting
to cancel an autovacuum worker.  It's possible (and has been seen in the
buildfarm) that the worker is already gone by the time we are able to
execute the kill, in which case the failure is harmless.  About the only
plausible reason for reporting such cases would be to help debug corrupted
lock table contents, but this is hardly likely to be the most important
symptom if that happens.  Moreover issuing a WARNING might scare users
more than is warranted.

Also, since sending a signal to an autovacuum worker is now entirely a
routine thing, and the worker will log the query cancel on its end anyway,
reduce the message saying we're doing that from LOG to DEBUG1 level.

Very minor cosmetic cleanup as well.

Since the main practical reason for doing this is to avoid unnecessary
buildfarm failures, back-patch to all active branches.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/47ee27521ac0a59e14b1f0f86d8cef1c7fa0ddff

Modified Files
--------------
src/backend/storage/lmgr/proc.c |   28 +++++++++++++++++++---------
1 file changed, 19 insertions(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Reduce chatter from signaling of autovacuum workers.
Next
From: Tom Lane
Date:
Subject: pgsql: Reduce chatter from signaling of autovacuum workers.