pgsql: Further code review for pg_stat_ssl patch. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Further code review for pg_stat_ssl patch.
Date
Msg-id E1ZJp1w-0006cq-9K@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Further code review for pg_stat_ssl patch.

Fix additional bogosity in commit 9029f4b37406b21a.  Include the
BackendSslStatusBuffer in the BackendStatusShmemSize calculation,
avoid ugly and error-prone casts to char* and back, put related
code stanzas into a consistent order (and fix a couple of previous
instances of that sin).  All cosmetic except for the size oversight.

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/cb0bb53204d84cecf51022313fe47d625de8f01e

Modified Files
--------------
src/backend/postmaster/pgstat.c |   65 +++++++++++++++++++++++----------------
1 file changed, 38 insertions(+), 27 deletions(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Fix pointer-arithmetic thinko in pg_stat_ssl patch.
Next
From: Stephen Frost
Date:
Subject: pgsql: Improve RLS handling in copy.c