pgsql: Fix treatment of nulls in jsonb_agg and jsonb_object_agg - Mailing list pgsql-committers

From Andrew Dunstan
Subject pgsql: Fix treatment of nulls in jsonb_agg and jsonb_object_agg
Date
Msg-id E1ZIdKO-0000Nv-9e@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix treatment of nulls in jsonb_agg and jsonb_object_agg

The wrong is_null flag was being passed to datum_to_json. Also, null
object key values are not permitted, and this was not being checked
for. Add regression tests covering these cases, and also add those tests
to the json set, even though it was doing the right thing.

Fixes bug #13514, initially diagnosed by Tom Lane.

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/016f28ad3dbf3bec14319cf2a49925b0063251aa

Modified Files
--------------
src/backend/utils/adt/jsonb.c         |   12 +++++++++---
src/test/regress/expected/json.out    |   21 ++++++++++++++++++++-
src/test/regress/expected/json_1.out  |   21 ++++++++++++++++++++-
src/test/regress/expected/jsonb.out   |   19 ++++++++++++++++++-
src/test/regress/expected/jsonb_1.out |   19 ++++++++++++++++++-
src/test/regress/sql/json.sql         |   13 +++++++++++--
src/test/regress/sql/jsonb.sql        |   12 +++++++++++-
7 files changed, 107 insertions(+), 10 deletions(-)


pgsql-committers by date:

Previous
From: Andres Freund
Date:
Subject: pgsql: Fix bug around assignment expressions containing indirections.
Next
From: Andrew Dunstan
Date:
Subject: pgsql: Fix treatment of nulls in jsonb_agg and jsonb_object_agg