pgsql: Fix add_rte_to_flat_rtable() for recent feature additions. - Mailing list pgsql-committers

Fix add_rte_to_flat_rtable() for recent feature additions.

The TABLESAMPLE and row security patches each overlooked this function,
though their errors of omission were opposite: RLS failed to zero out the
securityQuals field, leading to wasteful copying of useless expression
trees in finished plans, while TABLESAMPLE neglected to add a comment
saying that it intentionally *isn't* deleting the tablesample subtree.
There probably should be a similar comment about ctename, too.

Back-patch as appropriate.

Branch
------
REL9_5_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/41ae3b74d987d5d42f2c432812285c7d12d6f4c1

Modified Files
--------------
src/backend/optimizer/plan/setrefs.c |   12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)