pgsql: Fix (some of) pltcl memory usage - Mailing list pgsql-committers

From Alvaro Herrera
Subject pgsql: Fix (some of) pltcl memory usage
Date
Msg-id E1ZHA8G-0006ZW-10@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix (some of) pltcl memory usage

As reported by Bill Parker, PL/Tcl did not validate some malloc() calls
against NULL return.  Fix by using palloc() in a new long-lived memory
context instead.  This allows us to simplify error handling too, by
simply deleting the memory context instead of doing retail frees.

There's still a lot that could be done to improve PL/Tcl's memory
handling ...

This is pretty ancient, so backpatch all the way back.

Author: Michael Paquier and Álvaro Herrera
Discussion: https://www.postgresql.org/message-id/CAFrbyQwyLDYXfBOhPfoBGqnvuZO_Y90YgqFM11T2jvnxjLFmqw@mail.gmail.com

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/14ade020ffa805b8335af10a11520b7b2249c99e

Modified Files
--------------
src/pl/tcl/pltcl.c |   27 ++++++++++++++++++---------
1 file changed, 18 insertions(+), 9 deletions(-)


pgsql-committers by date:

Previous
From: Alvaro Herrera
Date:
Subject: pgsql: Fix (some of) pltcl memory usage
Next
From: Alvaro Herrera
Date:
Subject: pgsql: Fix (some of) pltcl memory usage