pgsql: Fix misuse of TextDatumGetCString(). - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: Fix misuse of TextDatumGetCString().
Date
Msg-id E1ZAlcj-0002oC-9e@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Fix misuse of TextDatumGetCString().

"TextDatumGetCString(PG_GETARG_TEXT_P(x))" is formally wrong: a text*
is not a Datum.  Although this coding will accidentally fail to fail on
all known platforms, it risks leaking memory if a detoast step is needed,
unlike "TextDatumGetCString(PG_GETARG_DATUM(x))" which is what's used
elsewhere.  Make pg_get_object_address() fall in line with other uses.

Noted while reviewing two-arg current_setting() patch.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/ac50f84866b22f239025bf37c9c7492cc4ce2dfd

Modified Files
--------------
src/backend/catalog/objectaddress.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Add an optional missing_ok argument to SQL function current_sett
Next
From: Tom Lane
Date:
Subject: pgsql: Fix misuse of TextDatumGetCString().