pgsql: Be more conservative about removing tablespace "symlinks". - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: Be more conservative about removing tablespace "symlinks".
Date
Msg-id E1Z8Zp4-0002v8-Ur@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Be more conservative about removing tablespace "symlinks".

Don't apply rmtree(), which will gleefully remove an entire subtree,
and don't even apply unlink() unless it's symlink or a directory,
the only things that we expect to find.

Amit Kapila, with minor tweaks by me, per extensive discussions
involving Andrew Dunstan, Fujii Masao, and Heikki Linnakangas,
at least some of whom also reviewed the code.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/8f15f74a44f68f9cb3a644786d3c732a5eeb237a

Modified Files
--------------
src/backend/access/transam/xlog.c |   24 ++--------
src/backend/commands/tablespace.c |   89 +++++++++++++++++++++++++++----------
src/include/commands/tablespace.h |    1 +
3 files changed, 69 insertions(+), 45 deletions(-)


pgsql-committers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: pgsql: release notes: Add entry for commit 5ea86e6e6.
Next
From: Robert Haas
Date:
Subject: pgsql: Fix grammar.